From caaace9eebf03cba32055410d522a901fc231694 Mon Sep 17 00:00:00 2001 From: Marko Lindqvist Date: Fri, 15 Nov 2024 18:08:00 +0200 Subject: [PATCH 71/71] packet_destroy(): Fix clang analyzer error Check against NULL handler in FREECIV_NDEBUG build too. See RM #1110 Signed-off-by: Marko Lindqvist --- common/generate_packets.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/common/generate_packets.py b/common/generate_packets.py index e12835308e..df38e02894 100755 --- a/common/generate_packets.py +++ b/common/generate_packets.py @@ -4194,8 +4194,10 @@ void packet_destroy(void *packet, enum packet_type type) }}; void (*handler)(void *packet) = (type < PACKET_LAST ? destroy_handlers[type] : nullptr); - fc_assert_action_msg(handler != nullptr, handler = free, - "packet_destroy(): invalid packet type %d", type); + if (handler == nullptr) {{ + handler = free; + log_error("packet_destroy(): Invalid packet type %d", type); + }} handler(packet); }} -- 2.45.2