From 7b8ab12117601069aa1414be2ffe3a6cdfccf9c4 Mon Sep 17 00:00:00 2001 From: Marko Lindqvist Date: Tue, 10 Jun 2025 04:44:54 +0300 Subject: [PATCH 86/86] Qt: Cleanup races_dialog slots parameters - Drop unused 'deselcted' parameters - Unify parameter names between the declaration and definition - Fix indentation issue on races_dialog::style_selected() See RM #1495 Signed-off-by: Marko Lindqvist --- client/gui-qt/dialogs.cpp | 12 +++++------- client/gui-qt/dialogs.h | 6 +++--- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/client/gui-qt/dialogs.cpp b/client/gui-qt/dialogs.cpp index 3e0a206290..55eeff8724 100644 --- a/client/gui-qt/dialogs.cpp +++ b/client/gui-qt/dialogs.cpp @@ -677,15 +677,15 @@ void races_dialog::update_nationset_combo() /***********************************************************************//** Selected group of nation ***************************************************************************/ -void races_dialog::group_selected(const QItemSelection &sl, - const QItemSelection &ds) +void races_dialog::group_selected(const QItemSelection &selected) { - QModelIndexList indexes = sl.indexes(); + QModelIndexList indexes = selected.indexes(); QModelIndex index ; if (indexes.isEmpty()) { return; } + index = indexes.at(0); set_index(index.row()); } @@ -754,8 +754,7 @@ void races_dialog::set_index(int index) /***********************************************************************//** Sets selected nation and updates style and leaders selector ***************************************************************************/ -void races_dialog::nation_selected(const QItemSelection &selected, - const QItemSelection &deselcted) +void races_dialog::nation_selected(const QItemSelection &selected) { char buf[4096]; QModelIndex index ; @@ -805,8 +804,7 @@ void races_dialog::nation_selected(const QItemSelection &selected, /***********************************************************************//** Sets selected style ***************************************************************************/ -void races_dialog::style_selected(const QItemSelection &selected, - const QItemSelection &deselcted) +void races_dialog::style_selected(const QItemSelection &selected) { QModelIndex index ; QVariant qvar; diff --git a/client/gui-qt/dialogs.h b/client/gui-qt/dialogs.h index 7b5ea0d3d3..d521cf4326 100644 --- a/client/gui-qt/dialogs.h +++ b/client/gui-qt/dialogs.h @@ -150,9 +150,9 @@ public: private slots: void set_index(int index); - void nation_selected(const QItemSelection &sl, const QItemSelection &ds); - void style_selected(const QItemSelection &sl, const QItemSelection &ds); - void group_selected(const QItemSelection &sl, const QItemSelection &ds); + void nation_selected(const QItemSelection &selected); + void style_selected(const QItemSelection &selected); + void group_selected(const QItemSelection &selected); void nationset_changed(int index); void leader_selected(int index); void ok_pressed(); -- 2.47.2