From b5092d78b2e6e4be0e2550ffb385db33fd567740 Mon Sep 17 00:00:00 2001 From: Dino Date: Sun, 26 Oct 2025 21:45:15 -0400 Subject: [PATCH] #1672 - Mac only fix for qt client disappearing "About..." menu items --- client/gui-qt/menu.cpp | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/client/gui-qt/menu.cpp b/client/gui-qt/menu.cpp index 72002fd564..306830e295 100644 --- a/client/gui-qt/menu.cpp +++ b/client/gui-qt/menu.cpp @@ -1711,16 +1711,28 @@ void mr_menu::setup_menus() }); act = menu->addAction(Q_(HELP_RULESET_ITEM)); +#ifdef __APPLE__ + // only needed on Mac, prevents qt from moving the menu item + act->setMenuRole(QAction::NoRole); +#endif // __APPLE__ QObject::connect(act, &QAction::triggered, [this]() { slot_help(HELP_RULESET_ITEM); }); act = menu->addAction(Q_(HELP_TILESET_ITEM)); +#ifdef __APPLE__ + // only needed on Mac, prevents qt from moving the menu item + act->setMenuRole(QAction::NoRole); +#endif // __APPLE__ QObject::connect(act, &QAction::triggered, [this]() { slot_help(HELP_TILESET_ITEM); }); act = menu->addAction(Q_(HELP_NATIONS_ITEM)); +#ifdef __APPLE__ + // only needed on Mac, prevents qt from moving the menu item + act->setMenuRole(QAction::NoRole); +#endif // __APPLE__ QObject::connect(act, &QAction::triggered, [this]() { slot_help(HELP_NATIONS_ITEM); }); @@ -1765,6 +1777,10 @@ void mr_menu::setup_menus() }); act = menu->addAction(Q_(HELP_ABOUT_ITEM)); +#ifdef __APPLE__ + // only needed on Mac, prevents qt from moving the menu item + act->setMenuRole(QAction::NoRole); +#endif // __APPLE__ QObject::connect(act, &QAction::triggered, [this]() { slot_help(HELP_ABOUT_ITEM); }); -- 2.31.0