From ea9a84e2cf6789b6d89f710b82a28da12e5f7806 Mon Sep 17 00:00:00 2001 From: Marko Lindqvist Date: Sun, 11 Oct 2026 08:03:34 +0300 Subject: [PATCH 93/93] cma_get_parameter(): Fix check against illegal data version See RM #2363 Signed-off-by: Marko Lindqvist --- client/agents/cma_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/client/agents/cma_core.c b/client/agents/cma_core.c index 0a6bb9e965..2ef64c0c63 100644 --- a/client/agents/cma_core.c +++ b/client/agents/cma_core.c @@ -587,13 +587,14 @@ bool cma_get_parameter(enum attr_city attr, int city_id, if (len == 0) { return FALSE; } - fc_assert_ret_val(len == SAVED_PARAMETER_SIZE || len == SAVED_PARAMETER_SIZE_OLD, + fc_assert_ret_val(len == SAVED_PARAMETER_SIZE + || len == SAVED_PARAMETER_SIZE_OLD, FALSE); dio_input_init(&din, buffer, len); dio_get_uint8_raw(&din, &version); - if (version > CMA_ATTR_VERSION && version < CMA_ATTR_VERSION_MIN_SUPPORTED) { + if (version > CMA_ATTR_VERSION || version < CMA_ATTR_VERSION_MIN_SUPPORTED) { log_error("CMA data has a wrong version %d (expected %d)", version, CMA_ATTR_VERSION); return FALSE; -- 2.53.0