Bug #1267
openciv2civ3 ruleset - mismatch between gov help and effect Unit_Upkeep_Free_Per_City
0%
Description
In the help for Government -> Federation it says -
"Each city can support up to 2 units for free; further units each cost 2 gold per turn."
but effects.ruleset has -
[effect_upkeep_free_units_federation]
type = "Unit_Upkeep_Free_Per_City"
value = 4
reqs =
{ "type", "name", "range", "quiet"
"Gov", "Federation", "Player", TRUE
"OutputType", "Gold", "Local", FALSE
}
Same problem for Fundamentalism.
Easy to fix, but which one is correct?
Files
Updated by Marko Lindqvist 7 days ago
Not sure, but this might be correct as it is. Each unit has upkeep of 2, so (free) upkeep of 2 units is 2x2=4 gold.
README.civ2civ3 likely has more to say about this.
Updated by Dean Brown 4 days ago
- File patch1267.diff patch1267.diff added
Did a deep dive into this and you are correct, the Upkeep_Factor is sometimes 2. Hard to understand the Upkeep_Factor reqs the way they are written.
But I did find a problem with the help displayed for units - most of them say
"Basic upkeep: 1 Food, 1 Shield, 1 Gold"
which is wrong, or at least very misleading. The actual upkeep is, depending on government, either "1 Shield", "1 Gold", or "2 Gold". I made an improvement by using the Shield2Gold_Factor effect, and, in units.ruleset, the ShieldToGold unit flag plus appropriate changes. With these changes the unit help says "1 Food, 1 Shield" and there's an auto generated help text saying "The 1 shield unit upkeep becomes 1 gold under Despotism and Monarchy, and 2 gold under Fundamentalism, Federation and Democracy.". Unfortunately you can't attach a "helptxt" to a predefined unit flag so I had to make a pseudo duplicate unit flag "ShieldToGold". And that new helptxt string would need translations.
Also wish I could edit the bug title.
Patch for 3.1