Feature #1292: gtk clients on Mac - use meta key instead of ctrl key for menu accelerator keys - Freeciv - Freeciv Ticket System

Actions

Copy link

Feature #1292

open

gtk clients on Mac - use meta key instead of ctrl key for menu accelerator keys

Added by Dean Brown 8 days ago. Updated 6 days ago.

Status:

New

Priority:

Normal

Assignee:

Category:

gtk3.22-client

Target version:

Start date:

04/14/2025

Due date:

% Done:

Estimated time:

Description

Mac standard is to use the "command"/"meta" key for the menu accelerator modifier key instead of ctrl key. The qt client already does this.

Files

Download all files

1292.patch (18.7 KB) 1292.patch		Dean Brown, 04/14/2025 05:54 AM
1292-gtk5.patch (8.39 KB) 1292-gtk5.patch		Dean Brown, 04/16/2025 01:57 AM

Actions

Copy link

Updated by Dean Brown 8 days ago

File 1292.patch 1292.patch added

fix for gtk3.22 & gtk4.

The helpdata.txt file uses "Ctrl" throughout the Help -> Controls section, and I was going to fix that too, but it also includes things that are not menus. While digging into that I discovered it's an even worse can of worms because the same help text is used in the qt client where it's even more wrong. Filing a new issue #1293 for that.

Actions

Copy link

Updated by Marko Lindqvist 8 days ago

For S3_3 & main, you should update also gui-gtk-5.0 (which is actually using gtk4 at the moment), at least to make similar change to gui-gtk-4.0 if you can't test gtk5-client. (Same comment for all gtk patches you've done)

Actions

Copy link