Actions
Bug #1316
closedmeson: set warning level appropriately
Start date:
04/23/2025
Due date:
% Done:
0%
Estimated time:
Description
We currently set `-Wall` as a compiler option along with the other `-W` options, then apply that to the C and C++ compiler.
Meson warns us about this each time.
Compiler for C supports arguments -Wall: YES ../meson.build:53: WARNING: Consider using the built-in warning_level option instead of using "-Wall". Compiler for C++ supports arguments -Wall: YES ../meson.build:58: WARNING: Consider using the built-in warning_level option instead of using "-Wall".
We should make the suggested change as it:
- enables users or downstreams to configure warnings as they need / desire
- reduces configure noise
- is automatically applied to supported compilers
- is the 'meson way'
Files
Updated by Marko Lindqvist 3 months ago
- Related to Feature #1347: CodingStyle: Update autotools options to meson ones added
Updated by Marko Lindqvist 3 months ago
There's a PR for this in https://github.com/freeciv/freeciv/pull/73
Updated by Marko Lindqvist 3 months ago
- Target version set to 3.2.0-RC1
Patch from that PR applies to main branch, but we need versions for S3_3 and S3_2 too.
Updated by Marko Lindqvist about 2 months ago
- Target version changed from 3.2.0-RC1 to 3.2.1
Updated by Marko Lindqvist 21 days ago
- File 0049-meson-use-warning_level-default-option-instead-of-Wa.patch 0049-meson-use-warning_level-default-option-instead-of-Wa.patch added
- Status changed from New to In Review
- Assignee changed from Matt Jolly to Marko Lindqvist
Marko Lindqvist wrote in #note-3:
Patch from that PR applies to main branch, but we need versions for S3_3 and S3_2 too.
Attached. (same patch applies to both S3_3 and S3_2)
Actions