Project

General

Profile

Actions
Copy link

Bug #1483

open

gtk3.22 client - shortcut key for View menu item Show Stack Size doesn't work

Added by Dean Brown 3 months ago. Updated 30 days ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
gtk3.22-client
Target version:
-
Start date:
06/04/2025
Due date:
% Done:

0%

Estimated time:

Description

Seen in 3_1 and Main branch, gtk4 works OK. The shortcut key is "Ctrl/Meta +".

Discovered while working on #943, where I found that gtk doesn't like the plus (or minus) key by itself for a menu shortcut key. The code from gtk3.22 menu.c -

  { "SHOW_STACK_SIZE", N_("Unit Stack Size"),
    GDK_KEY_plus, ACCL_MOD_KEY,
    G_CALLBACK(show_stack_size_callback), MGROUP_SAFE },

In the gtk4 menu.c the struct menu_entry_info is different, code looks like this -

  { "SHOW_STACK_SIZE", N_("Unit Stack Size"),
    "show_stack_size", ACCL_MOD_KEY"plus", MGROUP_SAFE,
    show_stack_size_callback, FALSE },

Files

1483.patch (12.3 KB) 1483.patch Dean Brown, 07/28/2025 03:45 AM
Actions
Copy link
 #1

Updated by Marko Lindqvist 3 months ago

Cannot reproduce - works here.

Actions
Copy link
 #2

Updated by Dean Brown 3 months ago

Interesting - not the first time encountering a Mac-only bug. I may not be able to figure it out, should get a lower priority.

Actions
Copy link
 #3

Updated by Dean Brown about 1 month ago

OK, figured it out. Patch OK for all branches, and does not conflict with #943, although they both deal with the GDK_KEY_plus key.

I did find another different but unrelated problem with the GDK_KEY_plus key affecting sound volume. Opened #1630.

Actions
Copy link
 #4

Updated by Dean Brown 30 days ago

In #1630, Marko commented about keyboard layouts

(in Finnish keyboard '+' and '-' do not use any modifiers)

This would account for Marko saying he cannot reproduce this one.

Actions
Copy link

Also available in: Atom PDF