Bug #1634: Qt: action_function lacks some fake generalized actions (S3_2) - Freeciv - Freeciv Ticket System

Actions

Copy link

Bug #1634

closed

Qt: action_function lacks some fake generalized actions (S3_2)

Added by Marko Lindqvist about 1 year ago. Updated 19 days ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

Qt-client

Target version:

3.2.7

Start date:

07/29/2025

Due date:

% Done:

Estimated time:

Description

action_function in dialogs.cpp does not map many fake generalized actions to any function.

Files

Download all files

0071-Qt-Fix-activation-of-S3_2-fake-generalized-actions.patch (23.8 KB) 0071-Qt-Fix-activation-of-S3_2-fake-generalized-actions.patch	main, S3_3	Marko Lindqvist, 09/01/2026 07:46 PM
0031-Qt-Fix-activation-of-S3_2-fake-generalized-actions.patch (23.6 KB) 0031-Qt-Fix-activation-of-S3_2-fake-generalized-actions.patch	S3_2	Marko Lindqvist, 09/01/2026 07:47 PM

Related issues 6 (2 open — 4 closed)

Actions

Copy link

Updated by Marko Lindqvist about 1 year ago

Related to Bug #1629: Qt client - Collect Ransom not working added

Actions

Copy link

Updated by Marko Lindqvist about 1 month ago

Subject changed from Qt: action_function lacks some fake generalized actions to Qt: action_function lacks some fake generalized actions (S3_2)
Target version set to 3.2.7

Let's limit scope of this particular ticket to actions (added) in S3_2. Let's open separate tickets for actions added in later branches. The goal is to make this easier to tackle for the release branch.

Actions

Copy link

Updated by Marko Lindqvist about 1 month ago

1) The action_function related code really should be refactored, but it's outside scope of this ticket, and likely happens in main only. Let's just implement missing functions with the current pattern, no matter how poor it is.
2) Not all missing entries are fake generalized actions. As those might require more effort to implement correctly, let's keep also them outside the scope of this ticket. Let's concentrate on fake generalized actions only, and open separate tickets for others.

Actions

Copy link