Project

General

Profile

Actions
Copy link

Bug #1673

closed

Overflow in culture victory calculation

Added by Dean Brown 3 months ago. Updated 30 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Marko Lindqvist
Category:
Server
Target version:
3.1.6
Start date:
09/05/2025
Due date:
% Done:

0%

Estimated time:

Description

    if (best != NULL && best_value >= game.info.culture_vic_points
        && best_value > second_value * (100 + game.info.culture_vic_lead) / 100) {

If second_value > 7158277, the first multiplication exceeds 2**31 and overflows.

The back story - I made the history_interest_pml value too big in my custom ruleset, forgetting about what happens with compound interest. Culture values this big would never happen with supplied rulesets, but this should still get fixed.

Files

Download all files
1673.patch (817 Bytes) 1673.patch Dean Brown, 09/05/2025 04:27 AM
1673Main.patch (821 Bytes) 1673Main.patch Dean Brown, 09/30/2025 05:58 AM
Actions
Copy link
 #1

Updated by Dean Brown 3 months ago

Actions
Copy link
 #2

Updated by Marko Lindqvist 3 months ago

  • Category changed from General to Server
  • Target version set to 3.1.6

Patch does not apply to main branch.

Actions
Copy link
 #3

Updated by Dean Brown about 2 months ago

added patch for Main

Actions
Copy link
 #4

Updated by Marko Lindqvist about 2 months ago

  • Status changed from New to In Review
  • Assignee set to Marko Lindqvist
Actions
Copy link
 #5

Updated by Marko Lindqvist about 2 months ago

  • Status changed from In Review to Closed
Actions
Copy link
 #6

Updated by Marko Lindqvist about 1 month ago

  • Status changed from Closed to In Review

Apply also to S2_6.

Actions
Copy link
 #7

Updated by Marko Lindqvist 30 days ago

  • Status changed from In Review to Closed
Actions
Copy link

Also available in: Atom PDF