Project

General

Profile

Actions
Copy link

Bug #1684

closed

gtk clients have a problem with GDK_KEY_plus key and sound volume

Added by Dean Brown 12 months ago. Updated about 11 hours ago.

Status:
Closed
Priority:
High
Assignee:
Marko Lindqvist
Category:
gtk3.22-client
Target version:
3.3.0
Start date:
09/15/2025
Due date:
% Done:

0%

Estimated time:

Description

Spun off from #1630.

"+" key with GDK_SHIFT_MASK doesn't work to increase sound volume on American keyboards. The fix for #1630 replaces that functionality with menu items. After #1630 is done, the problematic code in gtk clients can go away.

Files

Download all files
1684_S3_3.patch (2.67 KB) 1684_S3_3.patch Dean Brown, 08/23/2026 07:25 AM
1684_Main.patch (3.98 KB) 1684_Main.patch Dean Brown, 08/23/2026 07:25 AM

Related issues 1 (1 open — 0 closed)

Blocks Tasks #2116: S3_3-alpha3NewMarko Lindqvist08/04/2026

Actions
Actions
Copy link
 #1

Updated by Marko Lindqvist 10 months ago

Is this a requirement for #943, or do I misread #1630 description?

Actions
Copy link
 #2

Updated by Dean Brown 10 months ago

I think this one is independent of #943.

Actions
Copy link
 #3

Updated by Dean Brown 10 months ago

The helpdata.txt also needs to be updated as part of this.

Actions
Copy link
 #4

Updated by Marko Lindqvist about 1 month ago

  • Priority changed from Normal to High

If I've understood correctly, nothing blocks this any more.

This, however, would be needed for freeciv-3.3 key arrangement freeze -> increasing priority.

Actions
Copy link Download all files
 #5

Updated by Dean Brown 16 days ago

The helpdata.txt has already been updated. This should be good to go.

Actions
Copy link
 #6

Updated by Marko Lindqvist 16 days ago

  • Status changed from New to In Review
  • Assignee set to Marko Lindqvist
  • Target version set to 3.3.0
Actions
Copy link
 #7

Updated by Marko Lindqvist 9 days ago

Actions
Copy link
 #8

Updated by Marko Lindqvist about 11 hours ago

  • Status changed from In Review to Closed
Actions
Copy link

Also available in: Atom PDF