Freeciv

This was with modified S3_2 HEAD. "Modified" meaning that some of the patches already submitted to this tracker are in the tree, notably #1820 that touches somewhat related code.

I had war_countdown() assert "adip->countdown == -1" failing.

I've found out that the reason for the war_countdown() is that the target has launched a spaceship. That code can be entered only if countdown < 0 and players are not at war (despite the < -1 countdown)

One possible explanation is that we've already going to war (have set countdown), but are still waiting for the senate to be dissolved.