Bug #1925: ruledit and ruleup output loses Road types: stuff - first_reqs & integrates - Freeciv - Freeciv Ticket System

Actions

Copy link

Bug #1925

closed

ruledit and ruleup output loses Road types: stuff - first_reqs & integrates

Added by Dean Brown about 1 month ago. Updated 15 days ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

Ruledit and ruleup

Target version:

3.2.3

Start date:

01/31/2026

Due date:

% Done:

Estimated time:

Description

seen in S3_2

File rulesave.c, save_terrain_ruleset() section for [road_0],[road_1], etc. is missing code to save first_reqs and integrates.

Files

Download all files

1925.patch (1.69 KB) 1925.patch		Dean Brown, 01/31/2026 09:30 PM
0003-rulesave-save-roads-first_reqs-and-integrates.patch (1.69 KB) 0003-rulesave-save-roads-first_reqs-and-integrates.patch	S2_6	Marko Lindqvist, 02/03/2026 02:49 AM

Related issues 1 (1 open — 0 closed)

Actions

Copy link

Updated by Dean Brown about 1 month ago

File 1925.patch added

Patch good for all branches.

Actions

Copy link

Updated by Marko Lindqvist about 1 month ago

      extra_type_list_iterate(proad->integrators, iextra) {
        set_count++;
      } extra_type_list_iterate_end;

I believe the extra_type_list_size() exist, to do this.

Actions

Copy link

Updated by Dean Brown about 1 month ago

File deleted (~~1925.patch~~)

Actions

Copy link

Updated by Dean Brown about 1 month ago

File 1925.patch 1925.patch added

Yes, improved patch.

Actions

Copy link

Updated by Marko Lindqvist about 1 month ago

Status changed from New to In Review
Assignee set to Marko Lindqvist
Target version set to 3.2.3

Actions

Copy link

Updated by Marko Lindqvist 29 days ago

Blocks Tasks #1845: Release 3.2.3 added

Actions

Copy link

Updated by Marko Lindqvist 28 days ago

I plan to apply this also to EoL branches S3_1 and S3_0. Heads of branches are occasionally used to port old savegames/rulesets to newer versions, even if the branch itself is already EoL.

Actions

Copy link