Project

General

Profile

Actions

Feature #2115

open

Qt client: improve city dialog UI design

Added by Dean Brown 26 days ago. Updated 5 days ago.

Status:
In Review
Priority:
Normal
Category:
Qt-client
Target version:
Start date:
08/04/2026
Due date:
% Done:

0%

Estimated time:

Description

After many years using the Qt client, I needed for the first time to set the "Allow disbanding city" option in the city dialog - and I could not find it. Finally tracked it down by reading the source code, and discovered a hidden feature that you can get a pop-up menu by clicking in the Worklist area. That menu is where the "Allow disbanding city" option is found. This is not good UI design, there's no documentation of this hidden feature and users would never discover it. So I changed the UI design.

I repurposed the (unlabeled) "Counters" button to instead pop-up the menu, and added a "Counters" menu item to the menu. That menu item shows the Counters pane, which I enhanced with a title bar and a close box. Before, the user would close the Counters pane by (non-obviously) clicking the "Counters" button again, now it's obvious how to close it. I changed the unlabeled button to have a label "Settings", and modified the tooltips, and tooltip handling. I also changed the "Show happiness..." button to have a more obviously meaningful icon - found a smiley face button on Wikimedia commons that is public domain. That button toggles its icon and tooltip as needed. The existing hidden method to get the pop-up menu is still there.

A little translation work needed.

Guessing targeting to 3.3, I could make a separate patch for 3.2 if desired.


Files

2115.patch (15.2 KB) 2115.patch Dean Brown, 08/24/2026 01:15 AM
Actions #1

Updated by Dean Brown 26 days ago

  • File 2115.patch added
Actions #2

Updated by Dean Brown 26 days ago

  • File 2115_Part2.patch added

Oops, forgot to add the new smiley.png file to meson.build, needs to get installed.

Actions #3

Updated by Marko Lindqvist 25 days ago

  • Tracker changed from Tasks to Feature
  • Target version set to 3.3.0

Dean Brown wrote in #note-2:

Oops, forgot to add the new smiley.png file to meson.build, needs to get installed.

I don't see you handling autotools based build either.
Combine as a single patch, these make no sense as separate patches (it's just broken when you have just one applied)

Actions #4

Updated by Dean Brown 6 days ago

  • File deleted (2115.patch)
Actions #5

Updated by Dean Brown 6 days ago

  • File deleted (2115_Part2.patch)
Actions #6

Updated by Dean Brown 6 days ago

Duh, been using meson so long I forgot about autotools. OK let's do this right.

If only they supported wildcards like "*.png", would be so much easier.

Actions #7

Updated by Dean Brown 6 days ago

Actions #8

Updated by Marko Lindqvist 6 days ago

  • Status changed from New to In Review
  • Assignee set to Marko Lindqvist
Actions #9

Updated by Marko Lindqvist 5 days ago

Dean Brown wrote in #note-6:

Duh, been using meson so long I forgot about autotools.

The two major things we still need autotools for are the update-po, and release tarball creation. But if either process is broken, meson based builds will break too.

Actions

Also available in: Atom PDF