Project

General

Profile

Actions
Copy link

Feature #2214

open

gtk: Drop the self-assignment at the top of spy_steal_popup_shared()

Added by Marko Lindqvist 3 days ago. Updated 3 days ago.

Status:
In Review
Priority:
Normal
Assignee:
Marko Lindqvist
Category:
gtk4-client
Target version:
3.2.7
Start date:
09/05/2026
Due date:
% Done:

0%

Estimated time:

Description

darkdi provides PR https://github.com/freeciv/freeciv/pull/89
to drop pointless self-assignment of args->act_id in gtk-clients' spy_steal_popup_shared()

Files

0039-gtk-Drop-the-self-assignment-at-the-top-of-spy_steal.patch (1.34 KB) 0039-gtk-Drop-the-self-assignment-at-the-top-of-spy_steal.patch S3_3, S3_2 Marko Lindqvist, 09/05/2026 11:04 AM
Actions
Copy link
 #1

Updated by Marko Lindqvist 3 days ago

Patch in the PR should be fine for main branch, except for the commit message needing this ticket referenced. Backport for S3_3 and S3_2 attached here.

Actions
Copy link

Also available in: Atom PDF