Actions
Bug #2306
closedgtk4: Double destruction of diplomacy dialog
Start date:
09/29/2026
Due date:
% Done:
0%
Estimated time:
Description
Closing of the diplodlg (a gui_dialog) will destroy it. There's also conditional code to destroy it in diplomacy_destroy(). That's duplicate destruction (or at least use-after-free before deciding to abort the second destruction), when ever the condition in diplomacy_destroy() is fulfilled. All this leads to frequent crash some time after diplomacy dialog close.
Files
Actions
#1
Updated by Marko Lindqvist 15 days ago
- File 0077-gtk4-x-Fix-diplodlg-double-destruction.patch 0077-gtk4-x-Fix-diplodlg-double-destruction.patch added
- File 0036-gtk4-Fix-diplodlg-double-destruction.patch 0036-gtk4-Fix-diplodlg-double-destruction.patch added
- Status changed from New to In Review
- Assignee set to Marko Lindqvist
- Target version set to 3.2.7
Updated by Marko Lindqvist 15 days ago ยท Edited
The crashes seemed to happen especially on the client not accepting/cancelling the treaty last, but only receiving the close info from server, so use two clients connected to different players to reproduce. There's less reproducibility success with AI players.
Actions