Bug #2374
closedBuilding a city near unknown city fails with no feedback
0%
Description
I tried to build a city, it prompted me for a name, but then just didn't do anything, the settler was still on the square.
I assume there is a city I don't know about within citymindist, but there is no message.
(personally I think in this case the build city should succeed, but that's debatable and in any case a failure should always have some message).
Files
Updated by Marko Lindqvist 23 days ago
- Category set to Server
ACTION_PERFORM_UNIT_*() macros call illegal_action() with TRUE as the request_kind parameter. That's certainly wrong, as it should be an integer, not a boolean. It's less clear if REQEST_PLAYER_INITIATED (zero) would be the always right thing to pass, but at least it would make illegal_action() to emit notifications.
Updated by Marko Lindqvist 23 days ago
- File 0082-Fix-sending-explanations-about-failed-actions.patch 0082-Fix-sending-explanations-about-failed-actions.patch added
- File 0034-Fix-sending-explanations-about-failed-actions.patch 0034-Fix-sending-explanations-about-failed-actions.patch added
- Status changed from New to In Review
- Assignee set to Marko Lindqvist
- Target version set to 3.2.8
Marko Lindqvist wrote in #note-1:
It's less clear if REQEST_PLAYER_INITIATED (zero) would be the always right thing to pass
Patches based on the assumption that it is.
Updated by Andrew McGuinness 23 days ago
Note that REQEST is a misspelling, for a future fix. (REQUEST)