Project

General

Profile

Actions

Bug #2443

open

sdl3: using integer absolute value function 'abs' when argument is of floating point type

Added by Marko Lindqvist about 6 hours ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
sdl3-client
Target version:
-
Start date:
11/04/2026
Due date:
% Done:

0%

Estimated time:

Description

Building with clang:

FAILED: [code=1] freeciv-sdl3.p/client_gui-sdl3_gui_main.c.o 
clang -Ifreeciv-sdl3.p -I. -I../../src -I../../src/dependencies/luasql/src -I../../src/dependencies/tinycthread -I../../src/dependencies/tolua-5.2/include -I../../src/dependencies/cvercmp -I../../src/utility -I../../src/common -I../../src/common/networking -I../../src/common/scriptcore -I../../src/common/aicore -I../../src/client -I../../src/client/include -I../../src/client/luascript -I../../src/client/agents -I../../src/dependencies -I/usr/include/fribidi -I/usr/include/libdrm -I/usr/include/libdecor-0 -I/usr/include/opus -I/usr/include/x86_64-linux-gnu -I/usr/include/libpng16 -I/usr/include/webp -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -I/usr/include/freetype2 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O2 -g -Wnested-externs -Wmissing-declarations -Wpointer-arith -Wcast-align -Wmissing-prototypes -Wformat -Wformat-security -Wshadow -Wold-style-definition -Wtype-limits -Wimplicit-fallthrough -DHAVE_CONFIG_H -pthread -D_REENTRANT -MD -MQ freeciv-sdl3.p/client_gui-sdl3_gui_main.c.o -MF freeciv-sdl3.p/client_gui-sdl3_gui_main.c.o.d -o freeciv-sdl3.p/client_gui-sdl3_gui_main.c.o -c ../../src/client/gui-sdl3/gui_main.c
../../src/client/gui-sdl3/gui_main.c:583:32: error: using integer absolute value function 'abs' when argument is of floating point type [-Werror,-Wabsolute-value]
  583 |     if (((MOVE_STEP_X > 0) && (abs(event->motion.x - x) >= MOVE_STEP_X))
      |                                ^
../../src/client/gui-sdl3/gui_main.c:583:32: note: use function 'fabsf' instead
  583 |     if (((MOVE_STEP_X > 0) && (abs(event->motion.x - x) >= MOVE_STEP_X))
      |                                ^~~
      |                                fabsf
../../src/client/gui-sdl3/gui_main.c:584:35: error: using integer absolute value function 'abs' when argument is of floating point type [-Werror,-Wabsolute-value]
  584 |         || ((MOVE_STEP_Y > 0) && (abs(event->motion.y - y) >= MOVE_STEP_Y)) ) {
      |                                   ^
../../src/client/gui-sdl3/gui_main.c:584:35: note: use function 'fabsf' instead
  584 |         || ((MOVE_STEP_Y > 0) && (abs(event->motion.y - y) >= MOVE_STEP_Y)) ) {
      |                                   ^~~
      |                                   fabsf
2 errors generated.


Related issues 2 (2 open — 0 closed)

Blocks Task #2401: Release 3.2.8New10/21/2026

Actions
Blocks Feature #2344: Msys2: -Dwerror=trueIn ReviewMarko Lindqvist10/06/2026

Actions
Actions #1

Updated by Marko Lindqvist about 6 hours ago

Actions #2

Updated by Marko Lindqvist about 2 hours ago

Actions

Also available in: Atom PDF