Actions
Bug #2446
opengtk gui_stuff.c: Senseless "if (*(dlg->source))"
Start date:
11/07/2026
Due date:
% Done:
0%
Estimated time:
Description
gtk-clients have
if (*(dlg->source)) {
*(dlg->source) = NULL;
}somewhere (depends on the client and branch) in their gui_stuff.c.
That condition makes no sense, as simply nullifying pointed variable would be only faster than first checking if it's already NULL and then nullifying.
I think the intention has been to check that dlg->source itself is not NULL, so we wouldn't try to nullify address 0.
Files
Actions
#1
Updated by Marko Lindqvist 1 day ago
- File 0065-gtk-Correct-senseless-gui_dialog-check.patch 0065-gtk-Correct-senseless-gui_dialog-check.patch added
- File 0033-gtk-Correct-senseless-gui_dialog-check.patch 0033-gtk-Correct-senseless-gui_dialog-check.patch added
- Status changed from New to In Review
- Assignee set to Marko Lindqvist
Updated by Marko Lindqvist 1 day ago
- Blocks Bug #2447: build 3.2.7 is crashing on MacOS 27.2 added
Actions