Project

General

Profile

Actions

Bug #2446

open

gtk gui_stuff.c: Senseless "if (*(dlg->source))"

Added by Marko Lindqvist 1 day ago. Updated 1 day ago.

Status:
In Review
Priority:
Normal
Category:
gtk4-client
Target version:
Start date:
11/07/2026
Due date:
% Done:

0%

Estimated time:

Description

gtk-clients have

  if (*(dlg->source)) {
    *(dlg->source) = NULL;
  }

somewhere (depends on the client and branch) in their gui_stuff.c.
That condition makes no sense, as simply nullifying pointed variable would be only faster than first checking if it's already NULL and then nullifying.
I think the intention has been to check that dlg->source itself is not NULL, so we wouldn't try to nullify address 0.


Files


Related issues 1 (1 open — 0 closed)

Blocks Bug #2447: build 3.2.7 is crashing on MacOS 27.2In ReviewMarko Lindqvist11/07/2026

Actions
Actions #2

Updated by Marko Lindqvist 1 day ago

  • Blocks Bug #2447: build 3.2.7 is crashing on MacOS 27.2 added
Actions

Also available in: Atom PDF