Bug #460: action_sub_target_id_for_action() using uninitialized extra in case of pillage - Freeciv - Freeciv Ticket System

Actions

Copy link

Bug #460

closed

action_sub_target_id_for_action() using uninitialized extra in case of pillage

Added by Marko Lindqvist 7 months ago. Updated 7 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

Server

Target version:

3.1.2

Start date:

04/17/2024

Due date:

% Done:

Estimated time:

Description

action_sub_target_id_for_action() action_has_result(..ACTRES_PILLAGE) handling pass uninitialized extra pointer to unit_assign_specific_activity_target(). If that's not NULL, the call assumes it to be ok to begin with, and does not overwrite it. This lead to crash in later exter_number(pextra).

Files

Download all files

0050-Initialize-extra-before-calling-unit_assign_specific.patch (1.07 KB) 0050-Initialize-extra-before-calling-unit_assign_specific.patch	main, S3_2	Marko Lindqvist, 04/17/2024 12:41 AM
0018-Initialize-extra-before-calling-unit_assign_specific.patch (1.08 KB) 0018-Initialize-extra-before-calling-unit_assign_specific.patch	S3_1	Marko Lindqvist, 04/17/2024 12:41 AM