Bug #733: Qt: Avoid deprecated QMouseEvent::localPos() - Freeciv - Freeciv Ticket System

Actions

Copy link

Bug #733

closed

Qt: Avoid deprecated QMouseEvent::localPos()

Added by Marko Lindqvist 6 months ago. Updated 6 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

Qt-client

Target version:

3.1.2

Start date:

06/28/2024

Due date:

% Done:

Estimated time:

Description

QMouseEvent::localPos() is deprecated in favor of QMouseEvent::position() all Qt6 versions (i.e. already in 6.0). Thus we could, and I think should, use QMouseEvent::position() in Qt6 mode in all branches.

Files

0004-Qt6-Avoid-deprecated-QMouseEvent-localPos-call.patch (1.22 KB) 0004-Qt6-Avoid-deprecated-QMouseEvent-localPos-call.patch

Marko Lindqvist, 06/28/2024 12:55 PM

Actions

Copy link

Updated by Marko Lindqvist 6 months ago

Tracker changed from Feature to Bug
Target version changed from 3.1.3 to 3.1.2

S3_2 and main branch are already fine, only S3_1 is affected.

Why this is a bug: As localPos() is officially deprecated in Qt-6.0 already, compiler should give deprecation warning about its use in Qt6-mode. It seems we have avoided that warning thanks to Qt bug that despite the method being officially deprecated, its use was not properly checked. Now, with latest Qt versions in OpenEmbedded I'm getting the deprecation warning (and it's marked deprecated in 6.0, not only in those new versions where the check works)

Actions

Copy link