Project

General

Profile

Actions

Bug #835

closed

reqtext.c about squared distance wrong

Added by Marko Lindqvist 3 months ago. Updated 3 months ago.

Status:
Rejected
Priority:
Normal
Category:
General
Target version:
Start date:
09/07/2024
Due date:
% Done:

0%

Estimated time:

Description

if (preq->present) {
cat_snprintf(buf, bufsz,
_("The squared distance between the tiles "
"must be at most %d."),
preq->source.value.distance_sq);
} else {
cat_snprintf(buf, bufsz,
_("The squared distance between the tiles "
"must be at least %d."),
preq->source.value.distance_sq + 1);
}

I don't know which part is wrong, but this is inconsistent. The exact value can't fulfill both "present" and "not present" case. So either one should be "less than", or the other "more than".

Actions #1

Updated by Marko Lindqvist 3 months ago

  • Status changed from New to Rejected
  • Assignee set to Marko Lindqvist

Missed the "+ 1" in latter branch.

Actions

Also available in: Atom PDF