Project

General

Profile

Bug #1865 » 0056-Qt-Fix-flagless-unit-crash-on-action-selection-dialo.patch

Marko Lindqvist, 01/07/2026 01:22 AM

View differences:

client/gui-qt/dialogs.cpp
unit_name_translation(actor_unit),
city_name_get(target_city));
} else if (target_unit != nullptr) {
astr_set(&text,
// TRANS: Your Spy is ready to act against Roman Freight.
_("Your %s is ready to act against %s %s."),
unit_name_translation(actor_unit),
nation_adjective_for_player(unit_owner(target_unit)),
unit_name_translation(target_unit));
struct player *owner = unit_owner(target_unit);
if (owner != nullptr) {
astr_set(&text,
// TRANS: Your Spy is ready to act against Roman Freight.
_("Your %s is ready to act against %s %s."),
unit_name_translation(actor_unit),
nation_adjective_for_player(owner),
unit_name_translation(target_unit));
} else {
// Flagless target
astr_set(&text,
// TRANS: Your Spy is ready to act against Freight.
_("Your %s is ready to act against %s."),
unit_name_translation(actor_unit),
unit_name_translation(target_unit));
}
} else {
fc_assert_msg(target_unit != nullptr
|| target_city != nullptr
(4-4/4)