Project

General

Profile

Actions

Feature #1277

open

help for terrain alterations should tell about transform requiring adjacent tiles

Added by Dean Brown 2 months ago. Updated 7 days ago.

Status:
In Review
Priority:
Normal
Category:
client-common
Target version:
Start date:
04/01/2025
Due date:
% Done:

0%

Estimated time:

Description

From comments in terrain.ruleset -

; Percentage of "land" tiles required to be adjacent to a water tile before
; it may be "reclaimed" into a land tile (0-101; 0=anywhere, default 101=nowhere)
ocean_reclaim_requirement = 30

; Percentage of "water" tiles required to be adjacent to a land tile before
; it may be "channeled" into a water tile (0-101; 0=anywhere, default 101=nowhere)
land_channel_requirement = 10

If relevant, we should say how many adjacent land/water tiles are required to transform a tile.

Complication - terrain.ruleset file may include a transform from a land to ocean, or from ocean to land,
which then is not possible because the value of land_channel_requirement or ocean_reclaim_requirement
prevents it. If there is such a conflict, the *_requirement wins.


Files

patch1277.diff (4.15 KB) patch1277.diff Dean Brown, 04/01/2025 04:17 AM
1277Corrected.patch (4.01 KB) 1277Corrected.patch Dean Brown, 05/21/2025 04:27 AM
1277CorrectedPlural.patch (4.37 KB) 1277CorrectedPlural.patch Dean Brown, 05/28/2025 06:58 AM
Actions #1

Updated by Dean Brown 2 months ago

Patch from 3.1 branch, should work/merge OK for others.

Actions #2

Updated by Marko Lindqvist 19 days ago

- Indentation is (badly) off
- Do not force word order to translators, i.e., do not construct translatable strings by catenating substrings (in the order English expects them) but by providing format string for translators to adjust as they see fit.

Actions #3

Updated by Dean Brown 15 days ago

Some tab chars had sneaked in. Redid the translatable strings.

Actions #4

Updated by Marko Lindqvist 14 days ago

  • Status changed from New to In Review
  • Assignee set to Marko Lindqvist
  • Target version set to 3.1.6
Actions #5

Updated by Marko Lindqvist 10 days ago

  • Status changed from In Review to In Progress
  • Assignee changed from Marko Lindqvist to Dean Brown

Do the pluralization properly with the PL macro, not with string like "tile(s)"

Actions #6

Updated by Dean Brown 8 days ago

That's a cool macro.

Actions #7

Updated by Marko Lindqvist 7 days ago

  • Status changed from In Progress to In Review
  • Assignee changed from Dean Brown to Marko Lindqvist
Actions

Also available in: Atom PDF