Project

General

Profile

Actions

Feature #1488

open

Make GTK and Qt clients menu items more similar

Added by Dean Brown 5 months ago. Updated 3 days ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
Qt-client
Target version:
Start date:
06/05/2025
Due date:
% Done:

0%

Estimated time:

Description

Spun off from #1293
Changes mostly to Qt client, items 2 & 5 are changes to GTK clients.

1
Unit menu item un(S)entry all on tile
Is Ctrl/Meta Shift D in Qt
"shift+s" is GTK only, Qt uses it for multiplayer_menu item "Set/Unset rally point",
and could use "shift+r" instead.

2
Qt has Ctrl/Meta F "Toggle city full bar visibility",
GTK View menu item "City Full Bar" lacking shortcut key,
because Ctrl/Meta F is GTK "Find City" menu item. GTK could use
Ctrl/Meta C for "Find _City" and then use Ctrl/Meta F for
"City _Full Bar" kike Qt.

3
Qt missing Meta-T shortcut for "Tax Rates..." menu item

4
Qt missing Shift-G shortcut for "Revolution" menu item

5
Qt has Ctrl/Meta + shift + J "Load Lua script"
GTK has menu item "Client _Lua Script" with no shortcut.

6
z: select only first unit of selected group
is shift+z in qt

7
Ctrl-Y: show/hide city outlines
Qt lacking this shortcut key.


Files

freeciv-keys.ods (27.9 KB) freeciv-keys.ods Marko Lindqvist, 06/06/2025 01:53 AM
1488_S3_2.patch (2.42 KB) 1488_S3_2.patch Dean Brown, 10/27/2025 05:11 AM
1488_S3_3_Main.patch (2.43 KB) 1488_S3_3_Main.patch Dean Brown, 10/27/2025 05:11 AM

Related issues 3 (1 open2 closed)

Related to Bug #1293: Help -> Controls is wrong for qt clientNew04/14/2025

Actions
Related to Feature #1497: Qt: Rally point key to "<ctrl><shift>r"ClosedMarko Lindqvist06/10/2025

Actions
Blocked by Feature #1541: Add specialist subtarget kindClosedMarko Lindqvist06/27/2025

Actions
Actions #1

Updated by Marko Lindqvist 5 months ago

  • Tracker changed from Tasks to Feature
  • Target version set to 3.3.0
Actions #2

Updated by Marko Lindqvist 5 months ago

For reference, partial list of keys from the time I last worked on making them more consistent and unified between clients. (Libreoffice spreadsheet)

Actions #3

Updated by Marko Lindqvist 5 months ago

  • Related to Bug #1293: Help -> Controls is wrong for qt client added
Actions #4

Updated by Marko Lindqvist 5 months ago

  • Related to Feature #1497: Qt: Rally point key to "<ctrl><shift>r" added
Actions #5

Updated by Dean Brown 4 months ago

  • File 1488patch.diff added

This patch just changes the QT client, and doesn't do the change in #1497.

I'm not sure the GTK clients should be changed (items 2 & 5 in the list). 2 - I expect the GTK "Find City" menu item gets used a lot and users might not like having its shortcut changed. 5 - is pretty trivial and likely not much used.

Actions #6

Updated by Dean Brown 4 months ago

  • File 1488Corrected.patch added

That was a bad patch, now corrected. Item 1 in the list needs to be part of the change in #1497.

Actions #7

Updated by Dean Brown 4 months ago

  • File 1488CorrectedAgain.patch added

Found another mistake. Shortcut for Government menu item "Revolution" should be "ctrl+shift+g" to match GTK.

Actions #8

Updated by Marko Lindqvist 4 months ago

Will need rebasing on top of #1541 on main branch.

Actions #9

Updated by Marko Lindqvist 4 months ago

Actions #10

Updated by Marko Lindqvist 3 months ago

  • Status changed from New to In Progress
  • Assignee set to Dean Brown
Actions #11

Updated by Marko Lindqvist about 2 months ago

Marko Lindqvist wrote in #note-8:

Will need rebasing on top of #1541 on main branch.

Ping

Actions #12

Updated by Dean Brown about 1 month ago

  • File 1488Main.patch added
  • File deleted (1488patch.diff)
  • File deleted (1488Corrected.patch)

rebased Main patch added.

Actions #13

Updated by Marko Lindqvist 9 days ago

Meanwhile S3_3 has changed so that the 1488CorrectedAgain.patch no longer applies cleanly there. (Suspects: #1671, #1497)

Actions #14

Updated by Dean Brown 3 days ago

  • File 1488_S3_3.patch added
Actions #15

Updated by Dean Brown 3 days ago

added 1488_S3_3.patch

Updated by Dean Brown 3 days ago

Same problem with Main, so I renamed the patches.

Actions #17

Updated by Dean Brown 3 days ago

  • File deleted (1488CorrectedAgain.patch)
Actions #18

Updated by Dean Brown 3 days ago

  • File deleted (1488_S3_3.patch)
Actions #19

Updated by Dean Brown 3 days ago

  • File deleted (1488Main.patch)
Actions

Also available in: Atom PDF