Project

General

Profile

Actions

Bug #1583

closed

Logic of is_action_possible()

Added by Alexandr Ignatiev 23 days ago. Updated 14 days ago.

Status:
Closed
Priority:
Normal
Category:
General
Target version:
Start date:
07/07/2025
Due date:
% Done:

0%

Estimated time:

Description

The variable out is assigned twice, shouldn't there be TRI_AND() whenever we get TRI_MAYBE in a later check? This is mostly harmless since clients make few difference between TRI_YES and TRI_MAYBE and servers should always get definite results. Ah, actres_possible() has a builtin effective tri-and with its def parameter. Thus we should just correct the distance check in main since player actions won't have an actor tile whatever the ATK_* is.


Files


Related issues 1 (0 open1 closed)

Blocks Feature #1597: Introduce is_action_enabled_player_on_*()ClosedMarko Lindqvist07/12/2025

Actions
Actions #1

Updated by Alexandr Ignatiev 20 days ago

  • Description updated (diff)
  • Target version changed from 3.1.6 to 3.4.0
Actions #2

Updated by Alexandr Ignatiev 19 days ago

Made. On the way it replaces all NULLs in the function. Not sure if it would be useful in 3.3.

Actions #4

Updated by Alexandr Ignatiev 19 days ago

  • Blocks Feature #1597: Introduce is_action_enabled_player_on_*() added
Actions #5

Updated by Marko Lindqvist 18 days ago

  • Status changed from New to In Review
  • Assignee set to Marko Lindqvist
Actions #6

Updated by Marko Lindqvist 14 days ago

  • Status changed from In Review to Closed
Actions

Also available in: Atom PDF