Freeciv

Well, certainly it should not be present=TRUE, as that would mean that Celebration is a requirement for the penalty.

One thing to note is that now the "CityStatus", "Celebration" checks for the real celebration status (at the previous turn change), not any of the temporary predictions during the turn. That said, it's also possible that celebration effects kick in one turn too late (even at the turn change where the celebration really starts, it might still check for the previous turn status)

Savegame to reproduce this would be nice, i.e. a savegame where there's a city celebrating but still suffering from the tile penalties.

Dug into this some - what I see is that, in requirements.c routine is_citystatus_req_active(), the value of context->city->rapture is always 0, even after multiple turns of rapture. Somehow the increment of pcity->rapture++; in cityturn.c routine update_city_activity() isn't getting propagated.

Could be that the 'rapture' is not sent to the client side. If this is such a client-side-only issue, it would mean that server does not actually apply penalties at turn change, it's just client showing that it would.

I think that this S3_3/main patch also needs to zero the fields on the client side when packet_short_city is received. Otherwise lost city keeps the values from the time it was still owned (or investigated) by the client's player-

For S3_2 we need a patch that does not break network compatibility, i.e., it needs to handle this with optional network capability.

Counters are not an issue - there's a separate struct packet_city_update_counters for them.

Yes network compatibility is an issue, tried using my patched client with test.cazfi.net server and got error "incompatible packet contents." Better to have someone else handle that - I'm more of a UI guy and not a network guy.

With the savegame you provided, I see no difference whether your patch has been applied or not. The central tile always has 2/3/1. It should be 2/4/1, I think.

Marko Lindqvist wrote in #note-9:

With the savegame you provided, I see no difference whether your patch has been applied or not. The central tile always has 2/3/1. It should be 2/4/1, I think.

Oh, the city was not celebrating yet, but starts celebrating only in two turns. I myself commented earlier that "it's also possible that celebration effects kick in one turn too late"