Actions
Bug #1784
opencitizens_unit_nationality() clang analyzer warning
Start date:
11/28/2025
Due date:
% Done:
0%
Estimated time:
Description
clang analyzer:
../../../src/server/citizenshand.c:158:10: warning: Null pointer passed to 1st parameter expecting 'nonnull' [core.NonNullParamChecker]
158 | return player_slot_get_player(dominant);
That can happen at least if pop_cost parameter is zero. No caller should set it so, though, so maybe just fc_assert() against such a parameter.
Files
Updated by Marko Lindqvist 14 days ago
- File 0047-Make-citizens_unit_nationality-more-robust.patch 0047-Make-citizens_unit_nationality-more-robust.patch added
- Status changed from New to In Review
- Assignee set to Marko Lindqvist
- Target version set to 3.2.2
Actions