Feature #1804
closedlua event signal for extra appearance/disappearance
0%
Description
Add a lua event signal for extra appearance/disappearance.
This touches the same piece of code in srv_main.c routine end_turn() that #1737 does, so should be blocked by #1737.
I would like this to get into 3.2.2, but there may be good reasons why most new lua stuff doesn't get into point releases and this would have to be for 3.3.
Files
Updated by Dean Brown about 2 months ago
- File 1804.patch added
This patch looks OK for all branches when done after Marko's patches for #1737 are applied.
Updated by Marko Lindqvist about 2 months ago
- Blocked by Feature #1737: improve reporting of appearing/disappearing extras added
Updated by Marko Lindqvist about 1 month ago
- If going by one signal (instead of separate ones for appearance and disappearance), maybe name it "spontaneous_extra"
- For telling the script what extra it is, rule_name should be used. For making user-visible messages, () and Q() can be used in the script.
Updated by Dean Brown about 1 month ago
- File 1804.patch 1804.patch added
Good suggestion about the signal name - I wasn't happy with my original idea.
Updated by Marko Lindqvist about 1 month ago
- Status changed from New to In Review
- Assignee set to Marko Lindqvist