Actions
Feature #1918
closedaccess_areas_refresh(): Check only existing tiledefs
Start date:
01/18/2026
Due date:
% Done:
0%
Estimated time:
Description
Currently access_areas_refresh() iterates tiledef checks up to MAX_TILEDEFS. It should check only actually existing tiledefs. Just use tiledef_iterate() which will do the right thing in this respect too.
While at it, also change pf iteration loop to be the outer one and tiledef iteration loop the inner one for slight performance boost (tiledef iteration is quicker one to run over and over again).
Files
Updated by Marko Lindqvist 24 days ago
- File 0065-access_areas_refresh-Iterate-tiledefs-with-tiledef_i.patch 0065-access_areas_refresh-Iterate-tiledefs-with-tiledef_i.patch added
- Status changed from New to In Review
- Assignee set to Marko Lindqvist
Updated by Marko Lindqvist 24 days ago
- File 0065-access_areas_refresh-Iterate-tiledefs-with-tiledef_i.patch 0065-access_areas_refresh-Iterate-tiledefs-with-tiledef_i.patch added
Do not break from the loops when one tiledef has been found - others might still need finding.
Updated by Marko Lindqvist 20 days ago
- Blocks Bug #1921: access_areas_refresh() calling tile_matches_tiledef() with nullptr tile added
Actions