Freeciv

Hello Freeciv team,

First, I would like to thank you for keeping alive this game!

I got a crash while playing Freeciv-gtk4-3.2.4-x86_64.AppImage. Here is the backtrace:

1: handle_city() CMA: Roskilde has changed multiple times.
3: Backtrace:
3:     0: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x2791e3) [0x55c5b277c1e3]
3:     1: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x2791bb) [0x55c5b277c1bb]
3:     2: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x282df9) [0x55c5b2785df9]
3:     3: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x278b58) [0x55c5b277bb58]
3:     4: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0xb65fc) [0x55c5b25b95fc]
3:     5: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0xb669d) [0x55c5b25b969d]
3:     6: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x15e5d7) [0x55c5b26615d7]
3:     7: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x15e657) [0x55c5b2661657]
3:     8: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x15e72c) [0x55c5b266172c]
3:     9: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x15ec7b) [0x55c5b2661c7b]
3:    10: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0xcc11f) [0x55c5b25cf11f]
3:    11: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x75f16) [0x55c5b2578f16]
3:    12: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/usr/bin/../lib/libglib-2.0.so.0(+0x5c385) [0x7f91ba5b8385]
3:    13: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/usr/bin/../lib/libglib-2.0.so.0(+0x5e5b7) [0x7f91ba5ba5b7]
3:    14: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/usr/bin/../lib/libglib-2.0.so.0(g_main_context_iteration+0x30) [0x7f91ba5bad20]
3:    15: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/usr/bin/../lib/libgio-2.0.so.0(g_application_run+0x1ed) [0x7f91ba815f1d]
3:    16: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x75423) [0x55c5b2578423]
3:    17: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0xc4e56) [0x55c5b25c7e56]
3:    18: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(main+0x25) [0x55c5b2577a6e]
3:    19: /lib/libc.so.6(+0x2a4d8) [0x7f91b9a554d8]
3:    20: /lib/libc.so.6(__libc_start_main+0x8b) [0x7f91b9a5559b]
3:    21: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x2fc61) [0x55c5b2532c61]
1: Please report this message at https://redmine.freeciv.org/projects/freeciv
3: Backtrace:
3:     0: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x2791e3) [0x55c5b277c1e3]
3:     1: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x2791bb) [0x55c5b277c1bb]
3:     2: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x282df9) [0x55c5b2785df9]
3:     3: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x2832b5) [0x55c5b27862b5]
3:     4: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x278bc5) [0x55c5b277bbc5]
3:     5: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0xb65fc) [0x55c5b25b95fc]
3:     6: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0xb669d) [0x55c5b25b969d]
3:     7: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x15e5d7) [0x55c5b26615d7]
3:     8: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x15e657) [0x55c5b2661657]
3:     9: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x15e72c) [0x55c5b266172c]
3:    10: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x15ec7b) [0x55c5b2661c7b]
3:    11: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0xcc11f) [0x55c5b25cf11f]
3:    12: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x75f16) [0x55c5b2578f16]
3:    13: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/usr/bin/../lib/libglib-2.0.so.0(+0x5c385) [0x7f91ba5b8385]
3:    14: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/usr/bin/../lib/libglib-2.0.so.0(+0x5e5b7) [0x7f91ba5ba5b7]
3:    15: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/usr/bin/../lib/libglib-2.0.so.0(g_main_context_iteration+0x30) [0x7f91ba5bad20]
3:    16: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/usr/bin/../lib/libgio-2.0.so.0(g_application_run+0x1ed) [0x7f91ba815f1d]
3:    17: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x75423) [0x55c5b2578423]
3:    18: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0xc4e56) [0x55c5b25c7e56]
3:    19: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(main+0x25) [0x55c5b2577a6e]
3:    20: /lib/libc.so.6(+0x2a4d8) [0x7f91b9a554d8]
3:    21: /lib/libc.so.6(__libc_start_main+0x8b) [0x7f91b9a5559b]
3:    22: /home/user/.cache/appimage-run/876b5183ebc020c51e75b68fc4cf86af414560e63640d9ebd5dd5242e1184da8/AppRun(+0x2fc61) [0x55c5b2532c61]
<Some Gtk-WARNING ...>
malloc(): unaligned fastbin chunk detected

The crash occurred while trying to trade cities with another nation controlled by AI. When adding the second city I was willing to trade the game crashed. I'm able to reproduce the crash using the "quitidle" save that was generated (freeciv-france-T0131-Y00600-quitidle.sav.zst):

• Try adding the player's city "Agnafit" to the deal in the attached save
• It doesn't work.
• Try adding it a second time.
• The game crashes.

Hopefully you can reproduce the issue.