Feature #851: fc_querysocket(): Check fdopen() return for NULL - Freeciv - Freeciv Ticket System

Actions

Copy link

Feature #851

closed

fc_querysocket(): Check fdopen() return for NULL

Added by Marko Lindqvist 3 months ago. Updated 3 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

General

Target version:

3.1.3

Start date:

09/13/2024

Due date:

% Done:

Estimated time:

Description

Passing fdopen() return value directly to fwrite() in fc_querysocket() causes clang-19 analyzer to give a warning. Check the value against NULL first.

Files

Download all files

0028-fc_querysocket-Handle-fdopen-errors.patch (1.66 KB) 0028-fc_querysocket-Handle-fdopen-errors.patch	main	Marko Lindqvist, 09/13/2024 06:14 PM
0013-fc_querysocket-Handle-fdopen-errors.patch (1.65 KB) 0013-fc_querysocket-Handle-fdopen-errors.patch	S3_2, S3_1	Marko Lindqvist, 09/13/2024 06:14 PM