Project

General

Profile

Actions
Copy link

Feature #1288

open

GTK client remember size of the options dlog

Added by Dean Brown about 1 month ago. Updated 3 days ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
gtk3.22-client
Target version:
3.1.6
Start date:
04/06/2025
Due date:
% Done:

0%

Estimated time:

Description

Similar to #1287, the qt client does it.

I haven't figured out how to yet, but will try.

Files

Download all files
1288-1time.patch (3.38 KB) 1288-1time.patch Dean Brown, 04/13/2025 04:13 AM
1288-alltime.patch (15.7 KB) 1288-alltime.patch Dean Brown, 04/13/2025 04:13 AM
1288-gtk5-alltime.patch (1.61 KB) 1288-gtk5-alltime.patch Dean Brown, 04/16/2025 01:56 AM
1288combined.patch (17 KB) 1288combined.patch Dean Brown, 05/04/2025 11:58 PM
Actions
Copy link Download all files
 #1

Updated by Dean Brown about 1 month ago

Found fixes for gtk3.22 & gtk4.

The 1time patch made from 3.1 branch, doesn't touch freeciv-client-rc-* file, saves the size during one runtime.

The alltime patch made from main branch, affects freeciv-client-rc-* file, saves the size across runtimes. This patch was created after the patch "#1287-main.patch" from issue #1287 was done.

Actions
Copy link
 #2

Updated by Dean Brown about 1 month ago

copy the fix into gtk5

Actions
Copy link
 #3

Updated by Marko Lindqvist 18 days ago

  • Target version set to 3.1.6
Actions
Copy link
 #4

Updated by Dean Brown 15 days ago

Replace files 1288-alltime.patch and 1288-gtk5-alltime.patch with 1288combined.patch

Actions
Copy link
 #5

Updated by Marko Lindqvist 3 days ago

- Some gtk-style "function ()" calls instead of freeciv style "function()"
- You should not add dummy options for already removed clients
- I'm not sure it's an improvement to replace dynamically adjusting option dialog width with hardcoded value that will be sensible/correct only for some users (font size etc).

Actions
Copy link

Also available in: Atom PDF