Project

General

Profile

Actions

Feature #1287

open

GTK client remember size of help dlg

Added by Dean Brown about 1 month ago. Updated 3 days ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
gtk3.22-client
Target version:
Start date:
04/06/2025
Due date:
% Done:

0%

Estimated time:

Description

This has bothered me ever since I first started with freeciv many years ago - having to always enlarge the help dlog. The qt client tracks its size already. I figured out how to do it for gtk3.22 (and gtk3, not that it matters), gtk4 does things differently.


Files

#1287-3.1.patch (2.64 KB) #1287-3.1.patch Dean Brown, 04/06/2025 07:30 AM
#1287-main.patch (13.8 KB) #1287-main.patch Dean Brown, 04/06/2025 07:30 AM
1287gtk4-1time.patch (1.68 KB) 1287gtk4-1time.patch Dean Brown, 04/13/2025 06:00 AM
1287gtk4-alltime.patch (1.46 KB) 1287gtk4-alltime.patch Dean Brown, 04/13/2025 06:00 AM
1287gtk5-alltime.patch (1.46 KB) 1287gtk5-alltime.patch Dean Brown, 04/16/2025 01:55 AM
1287combined.patch (16.1 KB) 1287combined.patch Dean Brown, 05/04/2025 11:35 PM

Updated by Dean Brown about 1 month ago

The 3.1 patch only remembers the size during one runtime. To remember it across runtimes requires storing the value in the options file freeciv-client-rc-xxx. Because we are so close to the 3.2.0 release and that data file formats are frozen and that the options file counts as a data file format, I did that patch for the main branch. I could be wrong, maybe it's OK to apply the main patch to 3.2?

Updated by Dean Brown about 1 month ago

Figured out the fix for gtk4.

The 1time patch made from 3.1 branch, doesn't touch freeciv-client-rc-* file, saves the size during one runtime.

The alltime patch made from main branch, affects freeciv-client-rc-* file, saves the size across runtimes. This patch was created after the patch "#1287-main.patch" was done.

Actions #3

Updated by Dean Brown about 1 month ago

copy the fix into gtk5

Actions #4

Updated by Marko Lindqvist 18 days ago

  • Target version set to 3.1.6
Actions #5

Updated by Dean Brown 15 days ago

Replace the files #1287-main.patch, 1287gtk4-alltime.patch and 1287gtk5-alltime.patch with 1287combined.patch

Actions #6

Updated by Marko Lindqvist 3 days ago

Can you provide single patch for S3_1/S3_2 too.

You should not add new options for already removed clients.

Actions

Also available in: Atom PDF