Feature #1287: GTK client remember size of help dlg - Freeciv - Freeciv Ticket System

Actions

Copy link

Feature #1287

open

GTK client remember size of help dlg

Added by Dean Brown 23 days ago. Updated 13 days ago.

Status:

New

Priority:

Normal

Assignee:

Category:

gtk3.22-client

Target version:

Start date:

04/06/2025

Due date:

% Done:

Estimated time:

Description

This has bothered me ever since I first started with freeciv many years ago - having to always enlarge the help dlog. The qt client tracks its size already. I figured out how to do it for gtk3.22 (and gtk3, not that it matters), gtk4 does things differently.

Files

Download all files

#1287-3.1.patch (2.64 KB) #1287-3.1.patch		Dean Brown, 04/06/2025 07:30 AM
#1287-main.patch (13.8 KB) #1287-main.patch		Dean Brown, 04/06/2025 07:30 AM
1287gtk4-1time.patch (1.68 KB) 1287gtk4-1time.patch		Dean Brown, 04/13/2025 06:00 AM
1287gtk4-alltime.patch (1.46 KB) 1287gtk4-alltime.patch		Dean Brown, 04/13/2025 06:00 AM
1287gtk5-alltime.patch (1.46 KB) 1287gtk5-alltime.patch		Dean Brown, 04/16/2025 01:55 AM

Actions

Copy link Download all files

Updated by Dean Brown 23 days ago

File #1287-3.1.patch #1287-3.1.patch added
File #1287-main.patch #1287-main.patch added

The 3.1 patch only remembers the size during one runtime. To remember it across runtimes requires storing the value in the options file freeciv-client-rc-xxx. Because we are so close to the 3.2.0 release and that data file formats are frozen and that the options file counts as a data file format, I did that patch for the main branch. I could be wrong, maybe it's OK to apply the main patch to 3.2?

Actions

Copy link Download all files

Updated by Dean Brown 16 days ago

File 1287gtk4-1time.patch 1287gtk4-1time.patch added
File 1287gtk4-alltime.patch 1287gtk4-alltime.patch added

Figured out the fix for gtk4.

The 1time patch made from 3.1 branch, doesn't touch freeciv-client-rc-* file, saves the size during one runtime.

The alltime patch made from main branch, affects freeciv-client-rc-* file, saves the size across runtimes. This patch was created after the patch "#1287-main.patch" was done.

Actions

Copy link