Project

General

Profile

Actions
Copy link

Feature #1495

open

Qt: races_dialog slot parameters cleanup

Added by Marko Lindqvist 6 days ago. Updated 6 days ago.

Status:
In Review
Priority:
Normal
Assignee:
Marko Lindqvist
Category:
Qt-client
Target version:
3.2.1
Start date:
06/10/2025
Due date:
% Done:

0%

Estimated time:

Description

Qt races_dialog private slots (nation_selected, style_selected, and group_selected) parameters have several issues:
- The 'deselected' parameter is unused, so can be dropped (it's also typoed, but that doesn't matter when it's dropped completely)
- Parameters have different names in .h and .cpp. Should be the clear one ("selected" instead of "sl" in both
- Indentation of style_selected() is off

Files

0086-Qt-Cleanup-races_dialog-slots-parameters.patch (3.12 KB) 0086-Qt-Cleanup-races_dialog-slots-parameters.patch Marko Lindqvist, 06/10/2025 04:48 AM
Actions
Copy link

Also available in: Atom PDF