Feature #1505
openMaxTopUnitsOnTile
0%
Description
Add requirement type "MaxTopUnitsOnTile". The difference to old "MaxUnitsOnTile" is that transported units are not counted, only topmost transporters.
Files
Updated by Marko Lindqvist 5 days ago
- File 0092-Add-MaxTopUnitsOnTile-requirement-type.patch 0092-Add-MaxTopUnitsOnTile-requirement-type.patch added
- Status changed from New to In Review
- Assignee set to Marko Lindqvist
Updated by Alexandr Ignatiev 5 days ago
Briefly looking, seems like in reqtext.c MAXTILETOPUNITS has inherited the doc from MAXTILEUNITS?
Updated by Marko Lindqvist 5 days ago
Alexandr Ignatiev wrote in #note-2:
Briefly looking, seems like in reqtext.c MAXTILETOPUNITS has inherited the doc from MAXTILEUNITS?
Yes. It's more correct for MAXTILETOPUNITS than MAXTILETOTALUNITS (renamed MAXTILEUNITS), for which the doc has been changed.
Updated by Alexandr Ignatiev 4 days ago
to
Marko Lindqvist wrote in #note-3:
Alexandr Ignatiev wrote in #note-2:
Briefly looking, seems like in reqtext.c MAXTILETOPUNITS has inherited the doc from MAXTILEUNITS?
Yes. It's more correct for MAXTILETOPUNITS than MAXTILETOTALUNITS (renamed MAXTILEUNITS), for which the doc has been changed.
Hmm... If I do not miss some patch, it said about number of units present on the tile(s). Really, the difference between "number of units" and "total number of units" does not sound very clear. At least we are used to that a unit that is inside Y which is in X is still present in X.
Updated by Marko Lindqvist 4 days ago
- Status changed from In Review to In Progress
Updated by Marko Lindqvist 4 days ago
- File 0082-Add-MaxTopUnitsOnTile-requirement-type.patch 0082-Add-MaxTopUnitsOnTile-requirement-type.patch added
- Status changed from In Progress to In Review
I changed MaxTopUnitOnTile reqtext.c messages to talk about units directly on the tile. Is this better?
Updated by Alexandr Ignatiev 4 days ago
Marko Lindqvist wrote in #note-6:
I changed MaxTopUnitOnTile reqtext.c messages to talk about units directly on the tile. Is this better?
Well, I'd use something like "untransported" or "(except ones in transports)", but tastes differ, it's already something :)
Updated by Marko Lindqvist 3 days ago
- Blocks Feature #1517: granularity: Allow max 4 units on tile added
Updated by Marko Lindqvist 1 day ago
- Status changed from In Review to In Progress
You're right "untransported" would be better. "directly on tile" is somewhat ambiguous when it comes to units inside cities or extras (fortresses).
Updated by Marko Lindqvist 1 day ago
- File 0075-Add-MaxTopUnitsOnTile-requirement-type.patch 0075-Add-MaxTopUnitsOnTile-requirement-type.patch added
- Status changed from In Progress to In Review
Marko Lindqvist wrote in #note-9:
You're right "untransported" would be better. "directly on tile" is somewhat ambiguous when it comes to units inside cities or extras (fortresses).
Changed the patch accordingly.