Freeciv

Oops, looking better at how actions are called, we can't query specific subtarget in an action enabler. Thus, to realize joining city as superspecialist, I will have to accomplish also plan A - make specialist a unit type field. Thus, superspecialist as a selectible subtarget remains for a player's action.

../../src/client/gui-sdl2/action_dialog.c: In function ‘simple_action_callback’:
../../src/client/gui-sdl2/action_dialog.c:814:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
814 | if (nullptr == specialist_by_number(sub_target)) { | ^
../../src/client/gui-sdl2/action_dialog.c:818:5: note: here
818 | case ASTK_NONE: | ^~~~

Likely same for sdl3-client.

This is in conflict with #1535, but I'm not yet sure which one should go in first, and which one needs to be rebased.

Marko Lindqvist wrote in #note-7:

This is in conflict with #1535, but I'm not yet sure which one should go in first, and which one needs to be rebased.

I think #1535 should go in first, as it has already been some time in my work stack and is ready to go in soon, whereas this ticket will anyway be subjected to autogame testing round first.

Will you rebase this.

Marko Lindqvist wrote in #note-10:

Will you rebase this.

Probably yes, I am slowly approaching to patches that make use of it to shape it better and get it tested.

savegame3.c:

'if (!loading->specialist.order[order_sub_tgt]) {'
with an untrusted order_sub_tgt value from a savegame might access memory outside the loading->specialist.order array.

currently out for a while, probably won't fix that in about a month