Bug #1562: PACKET_SYNC_SERIAL from non-player connection when starting tutorial - Freeciv - Freeciv Ticket System

Actions

Copy link

Bug #1562

closed

PACKET_SYNC_SERIAL from non-player connection when starting tutorial

Added by Marko Lindqvist 24 days ago. Updated 20 days ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

Server

Target version:

3.2.0-RC2

Start date:

07/04/2025

Due date:

% Done:

Estimated time:

Description

Seen in S3_2:
Selecting the tutorial scenario results in
"Received packet PACKET_SYNC_SERIAL(517) from a non-player connection..."

Likely server should just accept those packets.

Files

Download all files

0068-Accept-PACKET_SYNC_SERIAL-from-non-player-connection.patch (2.58 KB) 0068-Accept-PACKET_SYNC_SERIAL-from-non-player-connection.patch		Marko Lindqvist, 07/04/2025 11:44 PM
0025-Accept-PACKET_SYNC_SERIAL-from-non-player-connection.patch (3.1 KB) 0025-Accept-PACKET_SYNC_SERIAL-from-non-player-connection.patch		Marko Lindqvist, 07/05/2025 12:06 AM

Related issues 3 (0 open — 3 closed)

Actions

Copy link

Updated by Marko Lindqvist 24 days ago

File 0068-Accept-PACKET_SYNC_SERIAL-from-non-player-connection.patch 0068-Accept-PACKET_SYNC_SERIAL-from-non-player-connection.patch added
Category set to Server
Status changed from New to In Review
Assignee set to Marko Lindqvist
Target version set to 3.2.1

Actions

Copy link

Updated by Marko Lindqvist 24 days ago

File 0025-Accept-PACKET_SYNC_SERIAL-from-non-player-connection.patch 0025-Accept-PACKET_SYNC_SERIAL-from-non-player-connection.patch added
Target version changed from 3.2.1 to 3.2.0-RC2

In S3_2 (with npf), give optional network capability "unignoresync" for the fixed version. This is not yet used for anything, but will likely be needed when sync reply handling gets added. This also increases criticality of this fix, as we'd like the network protocol to have the capability in 3.2.0 already, for better interoperability with later releases -> targeting 3.2.0-RC2.

Actions

Copy link