Project

General

Profile

Actions

Feature #1587

closed

Client options save: Apply + save

Added by Marko Lindqvist 21 days ago. Updated 5 days ago.

Status:
Closed
Priority:
Normal
Category:
client-common
Target version:
Start date:
07/08/2025
Due date:
% Done:

0%

Estimated time:

Description

Currently "Save" button in the client options dialog does not necessarily save values that are visible in the dialog. It saves the values that user has clicked "Apply" for. It does not do the 'apply' automatically.

The challenge with automatic apply + save has been that the apply sends server settings to a round trip to the server, and they can be saved only once we've received them back from the server. To resolve that, PACKET_SYNC_SERIAL and PACKET_SYNC_SERIAL_REPLY have already been introduced to freeciv-3.2 and later. Now we only need to add the logic to postpone actual options saving until server has replied.


Files


Related issues 2 (1 open1 closed)

Blocked by Bug #1562: PACKET_SYNC_SERIAL from non-player connection when starting tutorialClosedMarko Lindqvist07/04/2025

Actions
Blocks Tasks #1612: Release 3.2.1NewMarko Lindqvist07/17/2025

Actions
Actions #1

Updated by Marko Lindqvist 21 days ago

  • Blocked by Bug #1562: PACKET_SYNC_SERIAL from non-player connection when starting tutorial added
Actions #3

Updated by Marko Lindqvist 11 days ago

Actions #4

Updated by Marko Lindqvist 5 days ago

  • Status changed from In Review to Closed
Actions

Also available in: Atom PDF