Freeciv

Dean Brown wrote:

In packets.def the disaster frequency is UINT8, needs to be UINT32. The ruleset value could in theory be as high as 1000000 if you wanted the disaster to always happen. Currently values > 255 get truncated.

The max should be 1000, I think, as it gets multiplied by the server setting that has max of 1000 (1000*1000=1000000). The server setting values that user may set should be meaningful, or the ruleset should lock the setting (to 1000).

Marko Lindqvist wrote in #note-2:

Dean Brown wrote:

In packets.def the disaster frequency is UINT8, needs to be UINT32. The ruleset value could in theory be as high as 1000000 if you wanted the disaster to always happen. Currently values > 255 get truncated.

The max should be 1000, I think

So correct type would be uint16. It's not that using the two extra bytes would be any way significant, but in the name of self-documenting code uint16 would show the intendet usage better.