Project

General

Profile

Actions
Copy link

Bug #1766

open

handle_unit_change_activity_real() may keep ACTIVITY_GOTO after clearing goto_tile

Added by Marko Lindqvist 1 day ago. Updated 1 day ago.

Status:
In Review
Priority:
Normal
Assignee:
Marko Lindqvist
Category:
Server
Target version:
3.2.2
Start date:
11/23/2025
Due date:
% Done:

0%

Estimated time:

Description

Inspection of goto_tile setters inspired by #1695 reported by John Robertson

handle_unit_change_activity_real() has some checks potentially resulting in early exit after goto_tile has been cleared. Such an early exit might leave previous ACTIVITY_GOTO activity intact. ACTIVITY_GOTO without valid goto_tile is an illegal combination.

Files

Download all files
0044-handle_unit_change_activity_real-Clear-goto_tile-lat.patch (1.33 KB) 0044-handle_unit_change_activity_real-Clear-goto_tile-lat.patch main Marko Lindqvist, 11/23/2025 10:04 PM
0027-handle_unit_change_activity_real-Clear-goto_tile-lat.patch (1.32 KB) 0027-handle_unit_change_activity_real-Clear-goto_tile-lat.patch S3_3, S3_2 Marko Lindqvist, 11/23/2025 10:04 PM

Related issues 1 (1 open — 0 closed)

Related to Bug #1695: SIGSEGV from NULL punit->goto_tileNew09/29/2025

Actions
Actions
Copy link

Also available in: Atom PDF