Project

General

Profile

Actions

Feature #1804

open

lua event signal for extra appearance/disappearance

Added by Dean Brown 23 days ago. Updated 13 days ago.

Status:
In Review
Priority:
Normal
Category:
Scripting API
Target version:
Start date:
12/09/2025
Due date:
% Done:

0%

Estimated time:

Description

Add a lua event signal for extra appearance/disappearance.

This touches the same piece of code in srv_main.c routine end_turn() that #1737 does, so should be blocked by #1737.

I would like this to get into 3.2.2, but there may be good reasons why most new lua stuff doesn't get into point releases and this would have to be for 3.3.


Files

1804.patch (1.8 KB) 1804.patch Dean Brown, 12/15/2025 04:43 AM

Related issues 2 (1 open1 closed)

Blocked by Feature #1737: improve reporting of appearing/disappearing extrasClosedMarko Lindqvist11/14/2025

Actions
Blocks Tasks #1751: S3_3-alpha2New11/22/2025

Actions
Actions #1

Updated by Dean Brown 23 days ago

  • File 1804.patch added

This patch looks OK for all branches when done after Marko's patches for #1737 are applied.

Actions #2

Updated by Marko Lindqvist 22 days ago

  • Target version set to 3.3.0-d3f
Actions #3

Updated by Marko Lindqvist 22 days ago

  • Blocked by Feature #1737: improve reporting of appearing/disappearing extras added
Actions #4

Updated by Marko Lindqvist 18 days ago

- If going by one signal (instead of separate ones for appearance and disappearance), maybe name it "spontaneous_extra"
- For telling the script what extra it is, rule_name should be used. For making user-visible messages, () and Q() can be used in the script.

Actions #5

Updated by Dean Brown 17 days ago

Good suggestion about the signal name - I wasn't happy with my original idea.

Actions #6

Updated by Dean Brown 17 days ago

  • File deleted (1804.patch)
Actions #7

Updated by Marko Lindqvist 13 days ago

  • Status changed from New to In Review
  • Assignee set to Marko Lindqvist
Actions #8

Updated by Marko Lindqvist 5 days ago

Actions

Also available in: Atom PDF