Project

General

Profile

Actions

Feature #1807

closed

the cases for city name attribution

Added by John Robertson 24 days ago. Updated 7 days ago.

Status:
Closed
Priority:
Normal
Category:
client-common
Target version:
Start date:
12/11/2025
Due date:
% Done:

0%

Estimated time:

Description

Case I: Identify cities being disbanded.
After taking over the cities of another player, especially an AI player, there is a need to prune the cities that are too close together.
file:///home/jro/.freeciv/city_ename/conquered.png

file:///home/jro/.freeciv/city_ename/allow-disband.png

During the game, dialog lists of city names allow the player to avoid sending/building resources in cities designated to be disbanded.

Case II: GoTo city that has an airport.

When moving units from the field, it is helpful to know which cities have airports and which do not.

Case III: show pollution risk cities that already has a Recycle Center improvement built.

For large cities, the pollution threat exists even when the city has a recycle center building improvement. Save time from the city list page to address only those cities that need the recycle center improvement.

Case IV: changing the city name (e.g. prefix 'x' for cities being disbanded) causes future cities to reuse previously used city names, causing confusion.


Files

clipboard-202512111209-vgnge.png (1.88 MB) clipboard-202512111209-vgnge.png John Robertson, 12/11/2025 09:09 PM
clipboard-202512111209-3eqwc.png (18.9 KB) clipboard-202512111209-3eqwc.png John Robertson, 12/11/2025 09:09 PM
1807.patch (15 KB) 1807.patch John Robertson, 12/11/2025 09:46 PM
1807.v2.patch (14.1 KB) 1807.v2.patch John Robertson, 12/14/2025 01:07 AM
1807.v3.patch (14.2 KB) 1807.v3.patch John Robertson, 12/20/2025 09:53 AM
Actions #1

Updated by John Robertson 24 days ago

Actions #2

Updated by Marko Lindqvist 24 days ago

- You should check things like whether the city has an airlift capability, not if it has a specifically named building (besides, you are comparing rule_name to name translated by _() -macro)

Actions #3

Updated by Marko Lindqvist 24 days ago

(e.g. In some rulesets "Airport" simply increases trade, and airlift capacity is granted by a tech)

Actions #4

Updated by John Robertson 22 days ago

migrated to gauge off of city_bonus_effects instead of buildings

Actions #5

Updated by Marko Lindqvist 18 days ago

  • Target version set to 3.4.0

- Replace EFT_AIRFLIFT != 0 with EFT_AIRLIFT > 0
- "if(is_city_option_set(pcity, CITYO_DISBAND)) {" missing space between 'if' and '('

Actions #6

Updated by John Robertson 16 days ago

revisions made, … thanks for the oversight.

Actions #7

Updated by Marko Lindqvist 11 days ago

  • Status changed from New to In Review
  • Assignee set to Marko Lindqvist
Actions #8

Updated by Marko Lindqvist 7 days ago

  • Status changed from In Review to Closed
Actions

Also available in: Atom PDF