Bug #1844: rulesave: bug saving helptext for Counters - Freeciv - Freeciv Ticket System

Actions

Copy link

Bug #1844

closed

rulesave: bug saving helptext for Counters

Added by Dean Brown about 2 months ago. Updated about 1 month ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

Ruledit and ruleup

Target version:

3.2.3

Start date:

12/27/2025

Due date:

% Done:

Estimated time:

Description

Repro -
1 edit sandbox/game.ruleset, add helptext="Helptext for Turn_Owned1" to the Turn_Owned1 Counter
2 run ruledit on the sandbox ruleset and save
3 the resulting game.ruleset in ruledit-tmp is now missing that helptext

Problem is in rulesave.c routine save_game_ruleset() -

      save_strvec(sfile, pcounter->helptext, "%s.helptext", path);

last 2 params are switched/wrong.

Files

Download all files

1844_S3_2.patch (931 Bytes) 1844_S3_2.patch		Dean Brown, 01/02/2026 03:37 AM
1844_S3_3&Main.patch (844 Bytes) 1844_S3_3&Main.patch		Dean Brown, 01/02/2026 03:37 AM

Related issues 2 (1 open — 1 closed)

Actions

Copy link

Updated by Dean Brown about 2 months ago

File 1844_S3_2.patch added
File 1844_S3_3&Main.patch added
Subject changed from ruledit: bug saving helptext for Counters to ruledit/ruleup: bug saving helptext for Counters

Also applies to ruleup.

Actions

Copy link