Project

General

Profile

Actions

Bug #2120

closed

found_new_tech() check of Marco Polo obsolescense broken

Added by Marko Lindqvist 2 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Category:
Server
Target version:
Start date:
08/05/2026
Due date:
% Done:

0%

Estimated time:

Description

found_new_tech() has:
/* Send all player an updated info of the owner of the Marco Polo * Wonder if this wonder has become obsolete. */
if (0 < had_embassies[i]
&& 0 <= get_player_bonus(aplayer, EFT_HAVE_EMBASSIES)) {

Fist line checks if player used to have the effect.
Last line is supposed to check if the player no longer have the effect (wonder has become obsolete). However, it's true when ever effect value is zero (disabled), or above (enabled). The only time it's not true when the effect value is below zero (disabled).


Files

Actions #1

Updated by Marko Lindqvist about 2 months ago

  • Description updated (diff)
Actions #2

Updated by Marko Lindqvist about 2 months ago

This only causes information to be sent unnecessarily to the client -> not targeting to the release branch.

Actions #3

Updated by Marko Lindqvist about 1 month ago

  • Status changed from In Review to Closed
Actions #4

Updated by Marko Lindqvist about 1 month ago

  • Status changed from Closed to In Review
  • Target version changed from 3.3.0 to 3.2.7

Marko Lindqvist wrote in #note-2:

This only causes information to be sent unnecessarily to the client -> not targeting to the release branch.

Not true. The bug can also cause information not to be sent when it should -> targeting also to S3_2 after all.
Already pushed to S3_3 and main.

Actions #5

Updated by Marko Lindqvist about 1 month ago

  • Status changed from In Review to Closed
Actions

Also available in: Atom PDF