Bug #2133: toluabind.c compile failure because of nullptr - Freeciv - Freeciv Ticket System

Actions

Copy link

Bug #2133

closed

toluabind.c compile failure because of nullptr

Added by Marko Lindqvist 17 days ago. Updated 8 days ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

General

Target version:

3.4.0

Start date:

08/13/2026

Due date:

% Done:

Estimated time:

Description

#1334 changed tolua generated code to use nullptr instead of NULL, but its own toluabind.c source file was not regenerated with the updated tolua. Now, after toluabind.c does get regenerated, it will cause compilation error with older compilers, as building that source does not include freeciv's headers setting up fallback nullptr.

The two options I see are to either make our copy of tolua freeciv -specific by making it depend on freeciv headers. or to partially(?) revert #1334.

Files

Download all files

0049-tolua-Use-NULL-instead-of-nullptr-in-toluabind.c.patch (26.2 KB) 0049-tolua-Use-NULL-instead-of-nullptr-in-toluabind.c.patch		Marko Lindqvist, 08/13/2026 02:35 AM
0041-tolua-Use-NULL-instead-of-nullptr-in-toluabind.c.patch (26.2 KB) 0041-tolua-Use-NULL-instead-of-nullptr-in-toluabind.c.patch		Marko Lindqvist, 08/15/2026 11:25 PM