Freeciv

Do you have any idea of the root cause - why isn't the order (->tolua) deterministic and requires such "fixing"?

In lua and most other hash implementations, there is a random seed used for the hash indexing to mitigate an attack that sends elements crafted specifically to all hash into the same bucket which would DoS the software. The downside is that iteration order becomes as random as the seed.

So we need to sort when iterating to get stable ordering out.

And there was a date added.

Marko Lindqvist wrote in #note-4:

did an additional round of building tolua + generating toluabind.c with it

And that breaks some CI jobs with this patch, because of #2133.

I think we need to go with Bernhard's original patch in main.