Actions
Feature #2221
closedgtk4: synchronize update_animation with idle tick
Start date:
09/06/2026
Due date:
% Done:
0%
Estimated time:
Description
Split from #2186 : One of the patches by caeies in PR https://github.com/freeciv/freeciv/pull/90 is
"gtk4: synchronize update_animation with idle tick.
in GTK4 you should not g_idle_add yourself during idle loop execution."
Files
Updated by Marko Lindqvist 23 days ago
Patch in PR:
- Function header for animation_tick_cb() has not been updated from animation_idle_cb() one - still speaks of idle callback
- Indentation is off (See doc/CodingStyle)
Updated by Marko Lindqvist 23 days ago
- Blocks Bug #2222: gtk4: fix proposal for resize stuff added
Updated by Caeies Caeies 22 days ago
I created a new PR as suggested : https://github.com/freeciv/freeciv/pull/93
Indentation should be ok.
Comment too (if it is suitable).
Thanks.
Updated by Marko Lindqvist 22 days ago
- File 0074-gtk4-x-Synchronize-update_animation-with-idle-tick.patch 0074-gtk4-x-Synchronize-update_animation-with-idle-tick.patch added
- Status changed from New to In Review
- Assignee set to Marko Lindqvist
- Target version set to 3.2.7
Patch from the PR applies to S3_3 and S3_2. Port for the main branch (just applying identical change also to gui-gtk-5.0) attached here.
Actions