Added by Marko Lindqvist 2 months ago. Updated about 2 months ago.
0%
Description
Split from #2186 : One of the patches by caeies in PR https://github.com/freeciv/freeciv/pull/90 is
"gtk4: synchronize update_animation with idle tick.
in GTK4 you should not g_idle_add yourself during idle loop execution."
Files
| 0074-gtk4-x-Synchronize-update_animation-with-idle-tick.patch (6.05 KB) 0074-gtk4-x-Synchronize-update_animation-with-idle-tick.patch | main | Marko Lindqvist, 09/07/2026 04:09 PM |
Patch in PR:
- Function header for animation_tick_cb() has not been updated from animation_idle_cb() one - still speaks of idle callback
- Indentation is off (See doc/CodingStyle)
I created a new PR as suggested : https://github.com/freeciv/freeciv/pull/93
Indentation should be ok.
Comment too (if it is suitable).
Thanks.
Patch from the PR applies to S3_3 and S3_2. Port for the main branch (just applying identical change also to gui-gtk-5.0) attached here.