Project

General

Profile

Actions

Feature #2247

closed

registry_ini.c: Stop adding gettext marking around empty strings

Added by Marko Lindqvist about 1 month ago. Updated 4 days ago.

Status:
Closed
Priority:
Normal
Category:
General
Target version:
Start date:
09/13/2026
Due date:
% Done:

0%

Estimated time:

Description

Split from #1893:

Do not place _() marking around empty string (""), even when gettext marking is requested. Do that with as clean an API as possible, though.


Files

2247.patch (1.07 KB) 2247.patch Dean Brown, 10/02/2026 05:51 AM

Related issues 1 (0 open — 1 closed)

Blocks Bug #1893: ruledit and ruleup output has issues with _() ClosedMarko Lindqvist01/08/2026

Actions
Actions #1

Updated by Marko Lindqvist about 1 month ago

  • Blocks Bug #1893: ruledit and ruleup output has issues with _() added
Actions #2

Updated by Marko Lindqvist about 1 month ago

  • Target version set to 3.3.0-beta1
Actions #3

Updated by Dean Brown 24 days ago

  • File 2247.patch added

This patch can also work for S3_2.

Actions #4

Updated by Marko Lindqvist 20 days ago

- We shouldn't silently override what caller requests. Maybe the best solution is to "return !gt_marking;" in case we set marking to FALSE, i.e., to return error if gt_marking is not what was requested.

- Check against empty strings with pentry->string.value0 != '\0', strlen() is quite heavy operation for that (esp. if the string happens to be long).

Actions #5

Updated by Marko Lindqvist 14 days ago

  • Status changed from New to In Progress
  • Assignee set to Dean Brown
Actions #6

Updated by Dean Brown 13 days ago

  • File deleted (2247.patch)
Actions #7

Updated by Dean Brown 13 days ago

fixed.

Actions #8

Updated by Marko Lindqvist 12 days ago

  • Status changed from In Progress to In Review
  • Assignee changed from Dean Brown to Marko Lindqvist
Actions #9

Updated by Marko Lindqvist 10 days ago

  • Target version changed from 3.3.0-beta1 to 3.2.7
Actions #10

Updated by Marko Lindqvist 4 days ago

  • Status changed from In Review to Closed
Actions

Also available in: Atom PDF